Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/829#discussion_r43552033
  
    --- Diff: 
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java
 ---
    @@ -76,20 +84,30 @@ public void schedule(Topologies topologies, Cluster 
cluster) {
                                 if (!nodesUsed.contains(targetNode.getId())) {
                                     nodesUsed.add(targetNode.getId());
                                 }
    +                            assignedMemOnHeap += 
targetSlot.getAllocatedMemOnHeap();
    +                            assignedMemOffHeap += 
targetSlot.getAllocatedMemOffHeap();
    +                            assignedCpu += targetSlot.getAllocatedCpu();
                             }
    -                        LOG.debug("Topology: {} assigned to {} nodes on {} 
workers", td.getId(), nodesUsed.size(), schedulerAssignmentMap.keySet().size());
    -                        cluster.setStatus(td.getId(), td.getId() + " Fully 
Scheduled");
    +                        LOG.debug("Topology: {} assigned to {} nodes on {} 
workers", td.getId(), nodesUsed.size(), assignedWorkers);
    +                        cluster.setStatus(td.getId(), "Fully Scheduled");
                         } catch (IllegalStateException ex) {
                             LOG.error(ex.toString());
    -                        LOG.error("Unsuccessfull in scheduling {}", 
td.getId());
    -                        cluster.setStatus(td.getId(), "Unsuccessfull in 
scheduling " + td.getId());
    +                        LOG.error("Unsuccessful in scheduling", 
td.getId());
    --- End diff --
    
    Thanks for fixing the typo, too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to