[
https://issues.apache.org/jira/browse/STORM-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983314#comment-14983314
]
ASF GitHub Bot commented on STORM-1144:
---------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/829#discussion_r43552033
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -76,20 +84,30 @@ public void schedule(Topologies topologies, Cluster
cluster) {
if (!nodesUsed.contains(targetNode.getId())) {
nodesUsed.add(targetNode.getId());
}
+ assignedMemOnHeap +=
targetSlot.getAllocatedMemOnHeap();
+ assignedMemOffHeap +=
targetSlot.getAllocatedMemOffHeap();
+ assignedCpu += targetSlot.getAllocatedCpu();
}
- LOG.debug("Topology: {} assigned to {} nodes on {}
workers", td.getId(), nodesUsed.size(), schedulerAssignmentMap.keySet().size());
- cluster.setStatus(td.getId(), td.getId() + " Fully
Scheduled");
+ LOG.debug("Topology: {} assigned to {} nodes on {}
workers", td.getId(), nodesUsed.size(), assignedWorkers);
+ cluster.setStatus(td.getId(), "Fully Scheduled");
} catch (IllegalStateException ex) {
LOG.error(ex.toString());
- LOG.error("Unsuccessfull in scheduling {}",
td.getId());
- cluster.setStatus(td.getId(), "Unsuccessfull in
scheduling " + td.getId());
+ LOG.error("Unsuccessful in scheduling",
td.getId());
--- End diff --
Thanks for fixing the typo, too.
> Display requested and assigned cpu/mem resources for schedulers in UI
> ---------------------------------------------------------------------
>
> Key: STORM-1144
> URL: https://issues.apache.org/jira/browse/STORM-1144
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Zhuo Liu
> Assignee: Zhuo Liu
> Attachments: index-page-0.png, topo-page-1.png, topo-page-2.png
>
>
> For CPU/Mem resource-aware schedulers, it is important for us to provide the
> feedback information about how much resources (onheap memory, offheap memory
> and CPU) have been requested by user and assigned by scheduler for each
> topology, on the UI pages.
> Tasks:
> 1. Calculate the requested and assigned onheap memory, offheap memory and CPU
> in resource-aware scheduler.
> 2. Add data structures and REST api to support these resources in topo-info,
> topo-summary, topo-page-info, cluster, core, nimbus.
> 3. Display assigned cpu/mem at the index page, and show more details about
> the requested and assigned resources at each topology page.
> 4. Adjust the items shown on UI (delete topoId item, exclude topoId from
> schedulerInfo). Update the restful API doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
