[ 
https://issues.apache.org/jira/browse/STORM-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984077#comment-14984077
 ] 

ASF GitHub Bot commented on STORM-40:
-------------------------------------

Github user harshach commented on the pull request:

    https://github.com/apache/storm/pull/835#issuecomment-152755528
  
    Thanks for the details @zhuoliu  I am +1 as well.  


> Turn worker GC logging and heapdump on by default
> -------------------------------------------------
>
>                 Key: STORM-40
>                 URL: https://issues.apache.org/jira/browse/STORM-40
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: James Xu
>            Assignee: Zhuo Liu
>
> https://github.com/nathanmarz/storm/issues/492
> This would be an update to the default worker.childopts. The logs should be 
> configured to have a ceiling on the amount of space they use.
> -----------------------------------------------------------------------------------------------------
> hausdorff:
> What sounds like a reasonable amount of default space for logging to you?
> -----------------------------------------------------------------------------------------------------
> mrflip:
> This is what we've been using; it will use no more than 10 files of 1MB each. 
> Most gc logging statements are on except PrintGCApplicationStoppedTime.
> worker.childopts: >-
>       -Xloggc:/var/log/storm/gc-worker-%ID%.log -verbose:gc                   
>                                                                               
>   
>       -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=10 -XX:GCLogFileSize=1m
>       -XX:+PrintGCDetails -XX:+PrintHeapAtGC -XX:+PrintGCTimeStamps 
> -XX:+PrintClassHistogram                                                      
>                                    
>       -XX:+PrintTenuringDistribution -XX:-PrintGCApplicationStoppedTime 
>                                                                               
>                                                                               
>                                             
> The challenge here is -Xloggc:/var/log/storm/gc-worker-%ID%.log -- how would 
> you like the directory to be specified? I can add a new config variable, or 
> add a new % interpolant, or default it to /tmp/gc-worker-%ID%.log.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to