[
https://issues.apache.org/jira/browse/STORM-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985877#comment-14985877
]
ASF GitHub Bot commented on STORM-1157:
---------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/842#issuecomment-153134999
It looks good to me. I am a little bit concerned that there is no way to
turn this off, partially or all the way. So for windows where there is
currently no support for this we will end up trying to run a shell script that
will fail, and if someone does not have/want commercial java support from
Oracle, i.e. using open JDK, or IBM JDK, etc. They have to make code
modifications, not just config modifications to not show users buttons that
will not work.
Could we put in something that could let users turn off part or all of this
feature? At a minimum in the UI, but it would be good if nimbus could also let
users know that this particular feature is not currently configured on, and if
the worker could see the config and know to add in
```-XX:+UnlockCommercialFeatures -XX:+FlightRecorder``` on the command line.
Other then that I am +1.
> Dynamic Worker Profiler - jmap, jstack, profiling and restarting worker
> -----------------------------------------------------------------------
>
> Key: STORM-1157
> URL: https://issues.apache.org/jira/browse/STORM-1157
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Kishor Patil
> Assignee: Kishor Patil
>
> In multi-tenant mode, storm launches long-running JVMs across cluster without
> sudo access to user. Self-serving of Java heap-dumps, jstacks and java
> profiling of these JVMs would improve users' ability to analyze and debug
> issues when monitoring it actively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
