Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/842#issuecomment-153134999
It looks good to me. I am a little bit concerned that there is no way to
turn this off, partially or all the way. So for windows where there is
currently no support for this we will end up trying to run a shell script that
will fail, and if someone does not have/want commercial java support from
Oracle, i.e. using open JDK, or IBM JDK, etc. They have to make code
modifications, not just config modifications to not show users buttons that
will not work.
Could we put in something that could let users turn off part or all of this
feature? At a minimum in the UI, but it would be good if nimbus could also let
users know that this particular feature is not currently configured on, and if
the worker could see the config and know to add in
```-XX:+UnlockCommercialFeatures -XX:+FlightRecorder``` on the command line.
Other then that I am +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
