Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r43770063
--- Diff: storm-core/src/clj/backtype/storm/cluster.clj ---
@@ -248,9 +256,9 @@
[id]
(str ASSIGNMENTS-SUBTREE "/" id))
-(defn code-distributor-path
- [id]
- (str CODE-DISTRIBUTOR-SUBTREE "/" id))
+(defn blobstore-path
+ [key]
+ (str BLOBSTORE-SUBTREE "/" key))
--- End diff --
This makes me a bit nervous, as key is a user provided value, and if we put
in a `..` or a `/` or something else malicious it could cause a security issue.
Are we checking elsewhere to prevent the key from having potentially harmful
characters in it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
