Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/825#discussion_r43772643
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -558,9 +566,14 @@ public static void validateFields(Map conf) throws
IllegalAccessException, Insta
* @param conf map of configs
* @param configClass config class
*/
- public static void validateFields(Map conf, Class configClass) throws
IllegalAccessException, InstantiationException, NoSuchFieldException,
NoSuchMethodException, InvocationTargetException {
+ public static void validateFields(Map conf, Class configClass) {
for (Field field : configClass.getFields()) {
- Object keyObj = field.get(null);
+ Object keyObj = null;
+ try {
+ keyObj = field.get(null);
+ } catch (IllegalAccessException e) {
+ throw new IllegalStateException("ConfigValidation failed
due to: " + e.getMessage() + "\n" + e.getStackTrace().toString());
--- End diff --
Same here, if we just don't want checked exceptions, we can wrap `e` in a
RTE.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
