[ 
https://issues.apache.org/jira/browse/STORM-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987931#comment-14987931
 ] 

ASF GitHub Bot commented on STORM-902:
--------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/848#discussion_r43794932
  
    --- Diff: storm-core/src/clj/backtype/storm/ui/core.clj ---
    @@ -843,14 +870,21 @@
         (populate-context! servlet-request)
         (assert-authorized-user "getClusterInfo")
         (json-response (nimbus-summary) (:callback m)))
    +  (GET "/api/v1/history/summary" [:as {:keys [cookies servlet-request]} & 
m]
    +    (let [user (.getUserName http-creds-handler servlet-request)]
    +      (json-response (topology-history-info user) (:callback m))))
       (GET "/api/v1/supervisor/summary" [:as {:keys [cookies servlet-request]} 
& m]
    -    (populate-context! servlet-request)
    -    (assert-authorized-user "getClusterInfo")
    -    (json-response (supervisor-summary) (:callback m)))
    +    (assert-authorized-user servlet-request "getClusterInfo")
    --- End diff --
    
    This needs to stay as populate-context! before calling 
assert-authorized-user, or the code will fail when security is enabled.


> Simple Log Search
> -----------------
>
>                 Key: STORM-902
>                 URL: https://issues.apache.org/jira/browse/STORM-902
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Zhuo Liu
>         Attachments: search-a-topology.png, search-for-a-single-worker-log.png
>
>
> In many debugging cases it would be nice to be able to do a simple search of 
> the logs of a topology directly from the UI.
> This is work that Yahoo has already done, but needs to be put back into open 
> source.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to