Github user d2r commented on the pull request:

    https://github.com/apache/storm/pull/845#issuecomment-153478106
  
    storm.thrift:
    
    ```
    struct AccessControl {
      1: required AccessControlType type;
      2: optional string name; //Name of user or group in ACL
      3: required i32 access; //bitmasks READ=0x1, WRITE=0x2, ADMIN=0x4
    }
    ```
    
    Really this should be a `union` of two types: `OtherAccessControl`, which 
lacks a `name`, and `UserAccessControl`, which requires `name`.
    
    It's invalid to have `type == AccessControlType.OTHER` and with a `name`, 
or to have `type == AccessControlType.USER` without a `name`.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to