[
https://issues.apache.org/jira/browse/STORM-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14989873#comment-14989873
]
ASF GitHub Bot commented on STORM-1163:
---------------------------------------
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/857
[STORM-1163] use rmr rather than rmpath for remove worker-root
In supervisor/try-cleaup-worker
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuoliu/storm 1163
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/857.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #857
----
commit 8d6ab39ac7d6625254c9dedd217b9d0ce63531fe
Author: zhuol <[email protected]>
Date: 2015-11-04T16:47:19Z
[STORM-1163] using rmr rather than rmpath for remove worker-root
----
> supervisor try-cleanup-worker should use rmr on the worker-root dir
> -------------------------------------------------------------------
>
> Key: STORM-1163
> URL: https://issues.apache.org/jira/browse/STORM-1163
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Reporter: Thomas Graves
> Assignee: Zhuo Liu
>
> Running the supervisor on latest master doesn't cleanup the workers
> directories properly. Exception:
> 2015-11-03 19:42:40.873 b.s.d.supervisor [WARN] Failed to cleanup worker
> 4b472318-84fa-452f-860b-4274e4b77c8e. Will retry later #error {
> :cause Failed to delete
> /home/user/teststorm/apache-storm-0.11.0-SNAPSHOT/storm-local/workers/4b472318-84fa-452f-860b-4274e4b77c8e
> :via
> [{:type java.lang.RuntimeException
> :message Failed to delete
> /home/user/teststorm/apache-storm-0.11.0-SNAPSHOT/storm-local/workers/4b472318-84fa-452f-860b-4274e4b77c8e
> :at [backtype.storm.util$rmpath invoke util.clj 570]}]
> :trace
> [[backtype.storm.util$rmpath invoke util.clj 570]
> [backtype.storm.daemon.supervisor$try_cleanup_worker invoke supervisor.clj
> 248]
> [backtype.storm.daemon.supervisor$shutdown_worker invoke supervisor.clj 286]
> [backtype.storm.daemon.supervisor$sync_processes invoke supervisor.clj 362]
> [clojure.core$partial$fn__4527 invoke core.clj 2492]
> [backtype.storm.event$event_manager$fn__6942 invoke event.clj 40]
> [clojure.lang.AFn run AFn.java 22]
> [java.lang.Thread run Thread.java 745]]}
> The issue is that the directory:
> /home/user/teststorm/apache-storm-0.11.0-SNAPSHOT/storm-local/workers/4b472318-84fa-452f-860b-4274e4b77c8e
> isn't empty and its trying to do rmpath which doesn't work when something in
> the directory.
> $ ls -la
> /home/user/teststorm/apache-storm-0.11.0-SNAPSHOT/storm-local/workers/4b472318-84fa-452f-860b-4274e4b77c8e
> lrwxrwxrwx 1 user users 110 Nov 3 19:05 artifacts ->
> /home/user/teststorm/apache-storm-0.11.0-SNAPSHOT/storm-local/workers-artifacts/wordcount-1-1446577532/6700
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
