[
https://issues.apache.org/jira/browse/STORM-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990364#comment-14990364
]
ASF GitHub Bot commented on STORM-1129:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/854#discussion_r43935881
--- Diff: storm-core/src/ui/public/component.html ---
@@ -116,7 +116,7 @@
var componentSummary = $("#component-summary");
var componentActions = $("#component-actions");
- var buttonJsonData =
componentActionJson(response["encodedTopologyId"], response["encodedId"],
response["id"],
+ var buttonJsonData = componentActionJson(response["name"],
response["encodedId"], response["id"],
--- End diff --
We need to encode the name just like we conded the topologyId, or we have
the possibility of an incorrect URL for odd characters in a topology name.
> Storm should use topology name instead of ids for url in storm UI.
> ------------------------------------------------------------------
>
> Key: STORM-1129
> URL: https://issues.apache.org/jira/browse/STORM-1129
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Reporter: Priyank Shah
> Assignee: Priyank Shah
>
> Currently, in storm UI details about a topology can be viewed at a URL which
> has a topology id as a query parameter. When a topology is updated and
> redeployed a new id is assigned by storm and existing URL(and any bookmarks
> relying on it) for the topology do not work since the id has changed. We
> should change it so that topology name is used instead of id.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
