Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/850#discussion_r43938005
  
    --- Diff: storm-core/pom.xml ---
    @@ -602,6 +612,42 @@
                               <pattern>org.eclipse.jetty</pattern>
                               
<shadedPattern>org.apache.storm.shade.org.eclipse.jetty</shadedPattern>
                             </relocation>
    +                        <relocation>
    +                            <pattern>com.codahale.metrics</pattern>
    +                            
<shadedPattern>org.apache.storm.shade.com.codahale.metrics</shadedPattern>
    +                        </relocation>
    --- End diff --
    
    If we are shading the codahale API the normal way of installing a custom 
metrics reporter is not going to work.  We should probably look at either not 
shading this, or at providing instructions on how to make other Reporters work. 
 But that can probably be in a follow on JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to