Github user knusbaum commented on a diff in the pull request:

    https://github.com/apache/storm/pull/838#discussion_r43952914
  
    --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Context.java ---
    @@ -55,6 +54,7 @@ public void prepare(Map storm_conf) {
             int maxWorkers = 
Utils.getInt(storm_conf.get(Config.STORM_MESSAGING_NETTY_CLIENT_WORKER_THREADS));
                ThreadFactory bossFactory = new 
NettyRenameThreadFactory("client" + "-boss");
             ThreadFactory workerFactory = new 
NettyRenameThreadFactory("client" + "-worker");
    +        // TODO investigate impact of having one worker
    --- End diff --
    
    I don't think we need this. I'm pretty sure this is a merge error / 
regression.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to