[
https://issues.apache.org/jira/browse/STORM-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990841#comment-14990841
]
ASF GitHub Bot commented on STORM-1159:
---------------------------------------
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/860#discussion_r43964164
--- Diff:
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/ExprCompiler.java
---
@@ -71,14 +49,10 @@
@Override
public String visitInputRef(RexInputRef rexInputRef) {
- if (expr.containsKey(rexInputRef)) {
- return expr.get(rexInputRef);
- }
- String name = reserveName(rexInputRef);
+ String name = reserveName();
String typeName = javaTypeName(rexInputRef);
pw.print(String.format("%s %s = (%s)(_data.get(%d));\n", typeName,
name,
- typeName, rexInputRef.getIndex()));
- expr.put(rexInputRef, name);
+ typeName, rexInputRef.getIndex()));
--- End diff --
indentation
> Support nullable operations in StormSQL
> ---------------------------------------
>
> Key: STORM-1159
> URL: https://issues.apache.org/jira/browse/STORM-1159
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-sql
> Reporter: Haohui Mai
> Assignee: Haohui Mai
>
> This jira tracks the efforts of supporting nullable types in StormSQL.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
