[ 
https://issues.apache.org/jira/browse/STORM-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991123#comment-14991123
 ] 

ASF GitHub Bot commented on STORM-1167:
---------------------------------------

Github user arunmahadevan commented on a diff in the pull request:

    https://github.com/apache/storm/pull/855#discussion_r43976038
  
    --- Diff: 
storm-core/src/jvm/backtype/storm/windowing/CountTriggerPolicy.java ---
    @@ -0,0 +1,62 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * <p/>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p/>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package backtype.storm.windowing;
    +
    +import java.util.concurrent.atomic.AtomicInteger;
    +
    +/**
    + * A trigger that tracks event counts and calls back {@link 
TriggerHandler#onTrigger()}
    + * when the count threshold is hit.
    + *
    + * @param <T> the type of event tracked by this policy.
    + */
    +public class CountTriggerPolicy<T> implements TriggerPolicy<T> {
    +    private final int count;
    +    private AtomicInteger currentCount;
    +    private TriggerHandler handler;
    --- End diff --
    
    Thanks, I missed it will make it final.


> Add sliding & tumbling window support for core storm
> ----------------------------------------------------
>
>                 Key: STORM-1167
>                 URL: https://issues.apache.org/jira/browse/STORM-1167
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Arun Mahadevan
>            Assignee: Arun Mahadevan
>
> Currently, topologies that needs windowing support requires writing custom 
> logic inside bolts making it tedious to handle the windowing and acking logic 
> with custom logic.
> We can add framework level support to core storm bolts to process tuples in a 
> time or a count based window. Sliding and tumbling windows can be supported.
> Later this can be extended to trident apis as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to