Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/855#discussion_r44019125
--- Diff:
storm-core/src/jvm/backtype/storm/windowing/TimeTriggerPolicy.java ---
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package backtype.storm.windowing;
+
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * Invokes {@link TriggerHandler#onTrigger()} after the duration.
+ */
+public class TimeTriggerPolicy<T> implements TriggerPolicy<T> {
+ private long duration;
+ private final TriggerHandler handler;
+ private final ScheduledExecutorService executor;
+
+ public TimeTriggerPolicy(long millis, TriggerHandler handler) {
+ this.duration = millis;
+ this.handler = handler;
+ this.executor = Executors.newSingleThreadScheduledExecutor();
+ start();
+ }
+
+ @Override
+ public void track(Event<T> event) {
+ // NOOP
+ }
+
+ @Override
+ public void reset() {
+ // NOOP
+ }
+
+ @Override
+ public void shutdown() {
+ executor.shutdown();
+ try {
+ if (!executor.awaitTermination(2, TimeUnit.SECONDS)) {
+ executor.shutdownNow();
+ }
+ } catch (InterruptedException ie) {
+ executor.shutdownNow();
+ Thread.currentThread().interrupt();
+ }
+ }
+
+ private void start() {
+ Runnable task = new Runnable() {
+ @Override
+ public void run() {
+ handler.onTrigger();
--- End diff --
I think we need some sort of error handling here, that can pass any
exceptions from the WondowedBolt back to the WindowedBoltExecutor so we can
exit the worker and fail fast on unhandled exceptions. As it stands now the
exception is just eaten.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
