Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r44365491
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -134,22 +131,16 @@ public void execute(Tuple tuple) {
collector.ack(t);
tupleBatch.clear();
}
+ } catch(SerializationError se) {
+ LOG.info("Serialization exception occurred, tuples will NOT be
acknowledged ", tuple);
--- End diff --
the message says tuple won't be acked and in next line we ack it, one of
the two is not right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
