[
https://issues.apache.org/jira/browse/STORM-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998042#comment-14998042
]
ASF GitHub Bot commented on STORM-1098:
---------------------------------------
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/862#discussion_r44373750
--- Diff:
storm-core/test/jvm/backtype/storm/nimbus/InMemoryTopologyAcitonNotifier.java
---
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package backtype.storm.nimbus;
+
+import java.util.Map;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.HashMap;
+
+public class InMemoryTopologyAcitonNotifier implements
ITopologyActionNotifierPlugin {
+
+ //static to ensure eventhough the class is created using reflection we
can still get
+ //the topology to actions
+ private static final Map<String, LinkedList<String>> topologyToActions
= new HashMap<>();
+
+
+ @Override
+ public void prepare(Map StormConf) {
+ //no-op
+ }
+
+ @Override
+ public synchronized void notify(String topologyName, String action) {
--- End diff --
This is not being invoked in critical (tuple execution) path so I think we
don't really care if this method is sync. Do you anticipate huge latencies here?
> Storm Nimbus Hook
> -----------------
>
> Key: STORM-1098
> URL: https://issues.apache.org/jira/browse/STORM-1098
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Sriharsha Chintalapani
> Assignee: Parth Brahmbhatt
>
> Apache Atlas provides governance services and also lineage. It will be great
> if we can capture the topology changes as part of Apache Atlas so that user
> can see how the topology changed over the period of time.
> Storm has ITaskHook but this is for topology components like spout & bolt.
> Similar to ITaskHook we should provide a nimbus hook that will allow
> pluggable implementations to run and can nimbus will execute this on any
> topology operation like upload jar, download, activate, deactivate , kill
> etc..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
