Github user danielschonfeld commented on the pull request:
https://github.com/apache/storm/pull/870#issuecomment-155558444
@revans2 i think we might have had different understandings about what I
was suggesting or maybe I just didn't understand the problem correctly.
I thought the objective was to reduce the number of threads in total. In
doing so, having only one single thread that goes to sleep constantly why
submitting the required flush to a global ExecutorService that will take care
of the **all** the flushing needed by all bolts/spouts on a single worker JVM.
In your implementation we still have a thread per DisruptorQueue doing
pretty much the same thing as before, but instead of doing the flushes on the
same thread, we split the tasks into a multi-threaded approach and try to do it
faster that way. That's not what I had intended with the above example.
I'd love to hear your thoughts on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
