[ 
https://issues.apache.org/jira/browse/STORM-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006718#comment-15006718
 ] 

ASF GitHub Bot commented on STORM-1016:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/706#discussion_r44928324
  
    --- Diff: storm-core/src/jvm/storm/trident/graph/GraphGrouper.java ---
    @@ -34,8 +31,8 @@
         
         public GraphGrouper(DirectedGraph<Node, IndexedEdge> graph, 
Collection<Group> initialGroups) {
             this.graph = graph;
    -        this.currGroups = new HashSet<>(initialGroups);
    -        reindex();      
    +        this.currGroups = new LinkedHashSet(initialGroups);
    --- End diff --
    
    Could you put the `<>` characters back at the end of the LinkedHashSet?


> Generate trident bolt ids with sorted group names
> -------------------------------------------------
>
>                 Key: STORM-1016
>                 URL: https://issues.apache.org/jira/browse/STORM-1016
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Jiasheng Wang
>
> In genBoltId() method of TridentTopology, groups are stored in HashSet. 
> So everytime I submit my trident topology, I get different id for my 
> component.
> For example, this time my bolt ids are (b-0-abc, b-1-def), next time they are 
> (b-1-abc, b-0-def). 
> It makes harder for users to track their metrics, and the bolt names in UI 
> are changing too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to