[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015136#comment-15015136 ]
ASF GitHub Bot commented on STORM-876: -------------------------------------- Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r45432788 --- Diff: storm-core/src/jvm/backtype/storm/blobstore/LocalFsBlobStore.java --- @@ -0,0 +1,306 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package backtype.storm.blobstore; + +import backtype.storm.Config; +import backtype.storm.generated.SettableBlobMeta; +import backtype.storm.generated.AuthorizationException; +import backtype.storm.generated.KeyAlreadyExistsException; +import backtype.storm.generated.KeyNotFoundException; +import backtype.storm.generated.ReadableBlobMeta; + +import backtype.storm.nimbus.NimbusInfo; +import backtype.storm.utils.Utils; +import org.apache.curator.framework.CuratorFramework; +import org.apache.thrift.TBase; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.security.auth.Subject; +import java.io.ByteArrayOutputStream; +import java.io.File; +import java.io.IOException; +import java.io.FileNotFoundException; +import java.io.InputStream; + +import java.util.*; + +import static backtype.storm.blobstore.BlobStoreAclHandler.ADMIN; +import static backtype.storm.blobstore.BlobStoreAclHandler.READ; +import static backtype.storm.blobstore.BlobStoreAclHandler.WRITE; + +/** + * Provides a local file system backed blob store implementation for Nimbus. + */ +public class LocalFsBlobStore extends BlobStore { + public static final Logger LOG = LoggerFactory.getLogger(LocalFsBlobStore.class); + private static final String DATA_PREFIX = "data_"; + private static final String META_PREFIX = "meta_"; + protected BlobStoreAclHandler _aclHandler; + private final String BLOBSTORE_SUBTREE = "/blobstore/"; + private NimbusInfo nimbusInfo; + private FileBlobStoreImpl fbs; + private Map conf; + + @Override + public void prepare(Map conf, String overrideBase, NimbusInfo nimbusInfo) { + this.conf = conf; + this.nimbusInfo = nimbusInfo; + if (overrideBase == null) { + overrideBase = (String)conf.get(Config.BLOBSTORE_DIR); + if (overrideBase == null) { + overrideBase = (String) conf.get(Config.STORM_LOCAL_DIR); + } + } + File baseDir = new File(overrideBase, BASE_BLOBS_DIR_NAME); + try { + fbs = new FileBlobStoreImpl(baseDir, conf); + } catch (IOException e) { + throw new RuntimeException(e); + } + _aclHandler = new BlobStoreAclHandler(conf); + } + + @Override + public AtomicOutputStream createBlob(String key, SettableBlobMeta meta, Subject who) throws AuthorizationException, KeyAlreadyExistsException { + LOG.debug("Creating Blob for key {}", key); + validateKey(key); + _aclHandler.normalizeSettableBlobMeta(key, meta, who, READ | WRITE | ADMIN); + BlobStoreAclHandler.validateSettableACLs(key, meta.get_acl()); + _aclHandler.hasPermissions(meta.get_acl(), READ | WRITE | ADMIN, who, key); + if (fbs.exists(DATA_PREFIX+key)) { + throw new KeyAlreadyExistsException(key); + } + BlobStoreFileOutputStream mOut = null; + try { + mOut = new BlobStoreFileOutputStream(fbs.write(META_PREFIX+key, true)); + mOut.write(Utils.thriftSerialize((TBase) meta)); --- End diff -- `meta` is already a `TBase` > Dist Cache: Basic Functionality > ------------------------------- > > Key: STORM-876 > URL: https://issues.apache.org/jira/browse/STORM-876 > Project: Apache Storm > Issue Type: Improvement > Components: storm-core > Reporter: Robert Joseph Evans > Assignee: Robert Joseph Evans > Attachments: DISTCACHE.md, DistributedCacheDesignDocument.pdf > > > Basic functionality for the Dist Cache feature. > As part of this a new API should be added to support uploading and > downloading dist cache items. storm-core.ser, storm-conf.ser and storm.jar > should be written into the blob store instead of residing locally. We need a > default implementation of the blob store that does essentially what nimbus > currently does and does not need anything extra. But having an HDFS backend > too would be great for scalability and HA. > The supervisor should provide a way to download and manage these blobs and > provide a working directory for the worker process with symlinks to the > blobs. It should also allow the blobs to be updated and switch the symlink > atomically to point to the new blob once it is downloaded. > All of this is already done by code internal to Yahoo! we are in the process > of getting it ready to push back to open source shortly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)