[ 
https://issues.apache.org/jira/browse/STORM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022911#comment-15022911
 ] 

ASF GitHub Bot commented on STORM-885:
--------------------------------------

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/838#discussion_r45655066
  
    --- Diff: storm-core/src/jvm/backtype/storm/security/auth/AuthUtils.java ---
    @@ -276,4 +312,39 @@ public static String get(Configuration configuration, 
String section, String key
             }
             return null;
         }
    +
    +    private static final String USERNAME = "username";
    +    private static final String PASSWORD = "password";
    +
    +    public static String makeDigestPayload(Configuration login_config, 
String config_section) {
    +        String username = null;
    +        String password = null;
    +        try {
    +            Map<String, ?> results = AuthUtils.PullConfig(login_config, 
config_section);
    +            username = (String)results.get(USERNAME);
    +            password = (String)results.get(PASSWORD);
    +        }
    +        catch (Exception e) {
    +            LOG.error("Failed to pull username/password out of jaas conf", 
e);
    +        }
    +
    +        if(username == null || password == null) {
    +            return null;
    +        }
    +
    +        try {
    +            MessageDigest digest = MessageDigest.getInstance("SHA-512");
    +            byte[] output = digest.digest((username + ":" + 
password).getBytes());
    +
    +            StringBuilder builder = new StringBuilder();
    +            for(byte b : output) {
    +            builder.append(String.format("%02x", b));
    --- End diff --
    
    Check indent under `for`


> Heartbeat Server (Pacemaker)
> ----------------------------
>
>                 Key: STORM-885
>                 URL: https://issues.apache.org/jira/browse/STORM-885
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Kyle Nusbaum
>
> Large highly connected topologies and large clusters write a lot of data into 
> ZooKeeper.  The heartbeats, that make up the majority of this data, do not 
> need to be persisted to disk.  Pacemaker is intended to be a secure 
> replacement for storing the heartbeats without changing anything within the 
> heartbeats.  In the future as more metrics are added in, we may want to look 
> into switching it over to look more like Heron, where a metrics server is 
> running for each node/topology.  And can be used to aggregate/per-aggregate 
> them in a more scalable manor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to