[ 
https://issues.apache.org/jira/browse/STORM-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023705#comment-15023705
 ] 

ASF GitHub Bot commented on STORM-1220:
---------------------------------------

Github user arunmahadevan commented on the pull request:

    https://github.com/apache/storm/pull/894#issuecomment-159140476
  
    Overall it looks good. I think 
https://github.com/apache/storm/pull/894#discussion_r45434875 should be 
addressed. Otherwise it may break existing bolts.


> Avoid double copying in the Kafka spout
> ---------------------------------------
>
>                 Key: STORM-1220
>                 URL: https://issues.apache.org/jira/browse/STORM-1220
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>
> Currently the kafka spout takes a {{ByteBuffer}} from Kafka. However, the 
> serialization scheme takes a {{byte[]}} array as input. Therefore the current 
> implementation copies the {{ByteBuffer}} to a new {{byte[]}} array in order 
> to hook everything together.
> This jira proposes to changes the interfaces of serialization scheme to avoid 
> copying the data twice in the spout.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to