Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/885#issuecomment-159295188
+1 the code looks good to me. I agree with @wuchong that the logic is very
similar between the two and there is the potential to combine some code, them
but it is small enough I don't think it is that important.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
