[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025481#comment-15025481 ]
ASF GitHub Bot commented on STORM-876: -------------------------------------- Github user d2r commented on the pull request: https://github.com/apache/storm/pull/845#issuecomment-159413532 backtype.storm.utils.Utils After an upmerge, it looks like we cleaned up some duplicate method declarations. However, much of the remaining code is duplicated elsewhere. ``` 664 public static <T> T thriftDeserialize(Class c, byte[] b) { 665 try { 666 T ret = (T) c.newInstance(); 667 TDeserializer des = getDes(); 668 des.deserialize((TBase) ret, b); 669 return ret; 670 } catch (Exception e) { 671 throw new RuntimeException(e); 672 } 673 674 } ``` This should just call `Utils.thriftDeserialize(c, b, 0, b.length)` > Dist Cache: Basic Functionality > ------------------------------- > > Key: STORM-876 > URL: https://issues.apache.org/jira/browse/STORM-876 > Project: Apache Storm > Issue Type: Improvement > Components: storm-core > Reporter: Robert Joseph Evans > Assignee: Robert Joseph Evans > Attachments: DISTCACHE.md, DistributedCacheDesignDocument.pdf > > > Basic functionality for the Dist Cache feature. > As part of this a new API should be added to support uploading and > downloading dist cache items. storm-core.ser, storm-conf.ser and storm.jar > should be written into the blob store instead of residing locally. We need a > default implementation of the blob store that does essentially what nimbus > currently does and does not need anything extra. But having an HDFS backend > too would be great for scalability and HA. > The supervisor should provide a way to download and manage these blobs and > provide a working directory for the worker process with symlinks to the > blobs. It should also allow the blobs to be updated and switch the symlink > atomically to point to the new blob once it is downloaded. > All of this is already done by code internal to Yahoo! we are in the process > of getting it ready to push back to open source shortly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)