[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029570#comment-15029570
]
ASF GitHub Bot commented on STORM-876:
--------------------------------------
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46023509
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobSynchronizer.java
---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package backtype.storm.blobstore;
+
+import backtype.storm.nimbus.NimbusInfo;
+import backtype.storm.blobstore.BlobStoreUtils;
+import org.apache.curator.framework.CuratorFramework;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;;
+
+/**
+ * Is called periodically and updates the nimbus with blobs based on the
state stored inside the zookeeper
+ * for a non leader nimbus trying to be in sync with the operations
performed on the leader nimbus.
+ */
+public class BlobSynchronizer {
+ private static final Logger LOG =
LoggerFactory.getLogger(BlobSynchronizer.class);
+ private CuratorFramework zkClient;
+ private Map conf;
+ private BlobStore blobStore;
+ private Set<String> blobStoreKeySet = new HashSet<String>();
+ private Set<String> zookeeperKeySet = new HashSet<String>();
+ private NimbusInfo nimbusInfo;
+
+ public BlobSynchronizer(BlobStore blobStore, Map conf) {
+ this.blobStore = blobStore;
+ this.conf = conf;
+ }
+
+ public void setNimbusInfo(NimbusInfo nimbusInfo) {
+ this.nimbusInfo = nimbusInfo;
+ }
+
+ public void setZookeeperKeySet(Set<String> zookeeperKeySet) {
+ this.zookeeperKeySet = zookeeperKeySet;
+ }
+
+ public void setBlobStoreKeySet(Set<String> blobStoreKeySet) {
+ this.blobStoreKeySet = blobStoreKeySet;
+ }
+
+ public Set<String> getBlobStoreKeySet() {
+ Set<String> keySet = new HashSet<String>();
+ keySet.addAll(blobStoreKeySet);
+ return keySet;
+ }
+
+ public Set<String> getZookeeperKeySet() {
+ Set<String> keySet = new HashSet<String>();
+ keySet.addAll(zookeeperKeySet);
+ return keySet;
+ }
+
+ public synchronized void syncBlobs() {
+ try {
+ LOG.debug("Sync blobs - blobstore keys {}, zookeeper keys
{}",getBlobStoreKeySet(), getZookeeperKeySet());
+ zkClient = BlobStoreUtils.createZKClient(conf);
+ deleteKeySetFromBlobStoreNotOnZookeeper(getBlobStoreKeySet(),
getZookeeperKeySet());
+ updateKeySetForBlobStore(getBlobStoreKeySet());
+ Set<String> keySetToDownload =
getKeySetToDownload(getBlobStoreKeySet(), getZookeeperKeySet());
+ LOG.debug("Key set Blobstore-> Zookeeper-> DownloadSet {}-> {}-> {}",
getBlobStoreKeySet(), getZookeeperKeySet(), keySetToDownload);
+
+ for (String key : keySetToDownload) {
+ Set<NimbusInfo> nimbusInfoSet =
BlobStoreUtils.getNimbodesWithLatestSequenceNumberOfBlob(zkClient, key);
+ if(BlobStoreUtils.downloadMissingBlob(conf, blobStore, key,
nimbusInfoSet)) {
+ BlobStoreUtils.createStateInZookeeper(conf, key, nimbusInfo);
+ }
+ }
+ if (zkClient !=null) {
+ zkClient.close();
+ }
+ } catch(InterruptedException exp) {
+ LOG.error("InterruptedException {}", exp);
+ } catch(Exception exp) {
+ throw new RuntimeException(exp);
+ }
+ }
+
+ public void deleteKeySetFromBlobStoreNotOnZookeeper(Set<String>
keySetBlobStore, Set<String> keySetZookeeper) throws Exception {
+ if (keySetBlobStore.removeAll(keySetZookeeper)
+ || (keySetZookeeper.isEmpty() && !keySetBlobStore.isEmpty())) {
+ LOG.debug("Key set to delete in blobstore {}", keySetBlobStore);
+ for (String key : keySetBlobStore) {
+ blobStore.deleteBlob(key, BlobStoreUtils.getNimbusSubject());
+ }
+ }
+ }
+
+ // Update current key list inside the blobstore if the version changes
+ public void updateKeySetForBlobStore(Set<String> keySetBlobStore) {
+ try {
+ for (String key : keySetBlobStore) {
+ LOG.debug("updating blob");
+ BlobStoreUtils.updateKeyForBlobStore(conf, blobStore, zkClient,
key, nimbusInfo);
--- End diff --
not aligned indent
> Dist Cache: Basic Functionality
> -------------------------------
>
> Key: STORM-876
> URL: https://issues.apache.org/jira/browse/STORM-876
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Attachments: DISTCACHE.md, DistributedCacheDesignDocument.pdf
>
>
> Basic functionality for the Dist Cache feature.
> As part of this a new API should be added to support uploading and
> downloading dist cache items. storm-core.ser, storm-conf.ser and storm.jar
> should be written into the blob store instead of residing locally. We need a
> default implementation of the blob store that does essentially what nimbus
> currently does and does not need anything extra. But having an HDFS backend
> too would be great for scalability and HA.
> The supervisor should provide a way to download and manage these blobs and
> provide a working directory for the worker process with symlinks to the
> blobs. It should also allow the blobs to be updated and switch the symlink
> atomically to point to the new blob once it is downloaded.
> All of this is already done by code internal to Yahoo! we are in the process
> of getting it ready to push back to open source shortly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
