[
https://issues.apache.org/jira/browse/STORM-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036998#comment-15036998
]
ASF GitHub Bot commented on STORM-1086:
---------------------------------------
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/780#issuecomment-161484457
@kleinsch re-thinking a bit not sure if we need this Factory construct
given that this is single class will only be created once in when the spout
initializes. Why not try the following
1. add configure method to FailedMsgRetryManager
public interface FailedMsgRetryManager {
public void configure(Map<String,Object> config) or public void
configure(SpoutConfig config);
}
2. accept fully qualified class name as pluggable instance ( example look
for authorizer config in storm-core)
3. by default create instance of ExponentialBackoffMsgRetryManager . You
can use
https://github.com/apache/storm/blob/master/storm-core/src/jvm/backtype/storm/utils/Utils.java#L96
4. call configure method with spoutconfig so that it gets all the available
options
> Make FailedMsgRetryManager configurable when setting up KafkaSpout
> ------------------------------------------------------------------
>
> Key: STORM-1086
> URL: https://issues.apache.org/jira/browse/STORM-1086
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-kafka
> Reporter: Nick Kleinschmidt
> Assignee: Nick Kleinschmidt
> Priority: Minor
>
> The FailedMsgRetryManager interface makes replay behavior configurable and we
> default to using ExponentialBackoffMsgRetryManager, but there's no way to
> define your own FailedMsgRetryManager and plug it in when setting up
> KafkaSpout.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
