[ 
https://issues.apache.org/jira/browse/STORM-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038102#comment-15038102
 ] 

ASF GitHub Bot commented on STORM-1211:
---------------------------------------

Github user hmcl commented on a diff in the pull request:

    https://github.com/apache/storm/pull/915#discussion_r46578817
  
    --- Diff: 
external/storm-cassandra/src/test/java/org/apache/storm/cassandra/DynamicStatementBuilderTest.java
 ---
    @@ -116,15 +124,15 @@ private void 
executeStatementAndAssert(CQLStatementTupleMapper mapper, String...
             List<Statement> map = mapper.map(Maps.newHashMap(), 
cassandraCQLUnit.session, mockTuple);
     
             List<String> listExpected = Arrays.asList(expected);
    -        for( int i=0; i< map.size(); i++) {
    +        for (int i = 0; i < map.size(); i++) {
                 Assert.assertEquals(listExpected.get(i), 
map.get(i).toString());
             }
         }
     
         @Test
         public void shouldBuildStaticBoundStatement() {
    -        CQLStatementTupleMapper mapper = boundQuery("INSERT INTO 
weather.temperature(weatherstation_id, event_time, temperature) VALUES(?, ?, 
?)")
    -                .bind(with(field("weatherstation_id"), 
field("event_time").now(), field("temperature")));
    +        CQLStatementTupleMapper mapper = boundQuery("INSERT INTO 
weather.temperature(weather_station_id, event_time, temperature) VALUES(?, ?, 
?)")
    +                .bind(with(field("weather_station_id"), 
field("event_time").now(), field("temperature")));
    --- End diff --
    
    If this constants are expected to be used consistently, perhaps when 
expanding test cases, we could move them into pub stat fields.


> Add trident state and query support for cassandra connector
> -----------------------------------------------------------
>
>                 Key: STORM-1211
>                 URL: https://issues.apache.org/jira/browse/STORM-1211
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Satish Duggana
>            Assignee: Satish Duggana
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to