Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/915#discussion_r46578817
--- Diff:
external/storm-cassandra/src/test/java/org/apache/storm/cassandra/DynamicStatementBuilderTest.java
---
@@ -116,15 +124,15 @@ private void
executeStatementAndAssert(CQLStatementTupleMapper mapper, String...
List<Statement> map = mapper.map(Maps.newHashMap(),
cassandraCQLUnit.session, mockTuple);
List<String> listExpected = Arrays.asList(expected);
- for( int i=0; i< map.size(); i++) {
+ for (int i = 0; i < map.size(); i++) {
Assert.assertEquals(listExpected.get(i),
map.get(i).toString());
}
}
@Test
public void shouldBuildStaticBoundStatement() {
- CQLStatementTupleMapper mapper = boundQuery("INSERT INTO
weather.temperature(weatherstation_id, event_time, temperature) VALUES(?, ?,
?)")
- .bind(with(field("weatherstation_id"),
field("event_time").now(), field("temperature")));
+ CQLStatementTupleMapper mapper = boundQuery("INSERT INTO
weather.temperature(weather_station_id, event_time, temperature) VALUES(?, ?,
?)")
+ .bind(with(field("weather_station_id"),
field("event_time").now(), field("temperature")));
--- End diff --
If this constants are expected to be used consistently, perhaps when
expanding test cases, we could move them into pub stat fields.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
