[
https://issues.apache.org/jira/browse/STORM-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15051383#comment-15051383
]
ASF GitHub Bot commented on STORM-1175:
---------------------------------------
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/939#discussion_r47261403
--- Diff:
storm-core/test/jvm/backtype/storm/state/InMemoryKeyValueStateTest.java ---
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package backtype.storm.state;
+
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.junit.Assert.*;
+
+/**
+ * Unit tests for {@link InMemoryKeyValueState}
+ */
+public class InMemoryKeyValueStateTest {
+
+ KeyValueState<String, String> keyValueState;
+
+ @Before
+ public void setUp() {
+ keyValueState = new InMemoryKeyValueState<>();
+ }
+
+ @Test
+ public void testPutAndGet() throws Exception {
+ keyValueState.put("a", "1");
+ keyValueState.put("b", "2");
+ assertEquals("1", keyValueState.get("a"));
+ assertEquals("2", keyValueState.get("b"));
+ assertEquals(null, keyValueState.get("c"));
+ }
+
+ @Test
+ public void testPrepareCommitRollback() throws Exception {
+ keyValueState.put("a", "1");
+ keyValueState.put("b", "2");
+ keyValueState.prepareCommit(1);
+ keyValueState.put("c", "3");
+ assertEquals("1", keyValueState.get("a"));
--- End diff --
Please put all of this duplicated code in a helper method. All of this copy
and paste should be one line helper method call
> State store for windowing operations
> ------------------------------------
>
> Key: STORM-1175
> URL: https://issues.apache.org/jira/browse/STORM-1175
> Project: Apache Storm
> Issue Type: Sub-task
> Reporter: Arun Mahadevan
> Assignee: Arun Mahadevan
>
> Windowing operations should be able to save the results of partial
> computations in a state store. This should persist across restarts and bolts
> should be able to look up the values from the store.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
