Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/939#discussion_r47261403
--- Diff:
storm-core/test/jvm/backtype/storm/state/InMemoryKeyValueStateTest.java ---
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package backtype.storm.state;
+
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.junit.Assert.*;
+
+/**
+ * Unit tests for {@link InMemoryKeyValueState}
+ */
+public class InMemoryKeyValueStateTest {
+
+ KeyValueState<String, String> keyValueState;
+
+ @Before
+ public void setUp() {
+ keyValueState = new InMemoryKeyValueState<>();
+ }
+
+ @Test
+ public void testPutAndGet() throws Exception {
+ keyValueState.put("a", "1");
+ keyValueState.put("b", "2");
+ assertEquals("1", keyValueState.get("a"));
+ assertEquals("2", keyValueState.get("b"));
+ assertEquals(null, keyValueState.get("c"));
+ }
+
+ @Test
+ public void testPrepareCommitRollback() throws Exception {
+ keyValueState.put("a", "1");
+ keyValueState.put("b", "2");
+ keyValueState.prepareCommit(1);
+ keyValueState.put("c", "3");
+ assertEquals("1", keyValueState.get("a"));
--- End diff --
Please put all of this duplicated code in a helper method. All of this copy
and paste should be one line helper method call
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
