[
https://issues.apache.org/jira/browse/STORM-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052883#comment-15052883
]
ASF GitHub Bot commented on STORM-1377:
---------------------------------------
GitHub user d2r reopened a pull request:
https://github.com/apache/storm/pull/941
[STORM-1377] Correct timeouts for milliseconds
Thrift client timeouts had been given in seconds, when java.net.Socket
expects them in milliseconds.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/d2r/storm
storm-1377-auth-tests-correct-timeouts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/941.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #941
----
commit 402b8d215e2cebb7d7f15931aabaee695520f92d
Author: Derek Dagit <[email protected]>
Date: 2015-12-10T23:26:12Z
Correct timeouts to match units (milliseconds)
----
> nimbus_auth_test: very short timeouts causing spurious failures
> ---------------------------------------------------------------
>
> Key: STORM-1377
> URL: https://issues.apache.org/jira/browse/STORM-1377
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 0.10.0, 0.11.0
> Reporter: Derek Dagit
> Assignee: Derek Dagit
> Priority: Minor
>
> This is caused by a units mismatch. We are waiting 30 ms for the thrift
> server to reply when we thought we were waiting 30s. This means that
> sometimes when we expect NotAliveException, we instead get
> TTransportException(SocketTimeoutException), and this fails the assertions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
