[ 
https://issues.apache.org/jira/browse/STORM-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15057142#comment-15057142
 ] 

ASF GitHub Bot commented on STORM-1038:
---------------------------------------

Github user rfarivar commented on a diff in the pull request:

    https://github.com/apache/storm/pull/728#discussion_r47586615
  
    --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
    @@ -23,24 +23,17 @@
     import backtype.storm.metric.api.IStatefulObject;
     import backtype.storm.utils.StormBoundedExponentialBackoffRetry;
     import backtype.storm.utils.Utils;
    -import org.jboss.netty.bootstrap.ClientBootstrap;
    -import org.jboss.netty.channel.Channel;
    -import org.jboss.netty.channel.ChannelFactory;
    -import org.jboss.netty.channel.ChannelFuture;
    -import org.jboss.netty.channel.ChannelFutureListener;
    -import org.jboss.netty.util.HashedWheelTimer;
    -import org.jboss.netty.util.Timeout;
    -import org.jboss.netty.util.TimerTask;
    +import io.netty.bootstrap.Bootstrap;
    +import io.netty.channel.*;
    --- End diff --
    
    Could you please expand the imports?
    
    Also below. 


> Upgrade netty transport from 3.x to 4.x
> ---------------------------------------
>
>                 Key: STORM-1038
>                 URL: https://issues.apache.org/jira/browse/STORM-1038
>             Project: Apache Storm
>          Issue Type: Dependency upgrade
>          Components: storm-core
>            Reporter: Hang Sun
>            Priority: Minor
>              Labels: performance
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> It will be nice to upgrade netty to 4.x to take advantage of its more 
> efficient memory usage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to