Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/728#discussion_r47586860
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -182,7 +177,7 @@ private boolean connectionEstablished(Channel channel) {
// See:
// -
http://netty.io/3.9/api/org/jboss/netty/channel/ChannelEvent.html
// -
http://stackoverflow.com/questions/13356622/what-are-the-netty-channel-state-transitions
- return channel != null && channel.isConnected();
+ return channel != null && channel.isOpen();
--- End diff --
Why the change from connected to open? the channel could be open, but not
yet in the connected state, and this could cause a bug.
Unless Netty 4 has changed the model....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
