Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47681330
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java ---
@@ -430,12 +457,44 @@ public SupervisorDetails getSupervisorById(String
nodeId) {
}
/**
+ * set assignments for cluster
+ */
+ public void setAssignments(Map<String, SchedulerAssignment>
newAssignments) {
+ this.assignments = new HashMap<String, SchedulerAssignmentImpl>();
+ for (Map.Entry<String, SchedulerAssignment> entry :
newAssignments.entrySet()) {
--- End diff --
Looking at this snippet of code, it is not clear what the entry's key
contains. We just learn that it is a String, and is put in the assignments map
as a key again. This is why I like the other style of looping:
for (String representativeNameOfTheKeyString: newAssignments.keySet()) {
String representativeNameOfTheValueString:
newAssignments.get(representativeNameOfTheKeyString);
//do something with key and value
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
