Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47690000
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/RAS_Node.java ---
@@ -230,6 +241,61 @@ public void freeTopology(String topId, Cluster
cluster) {
_topIdToUsedSlots.remove(topId);
}
+ private void freeMemory(double amount) {
+ _availMemory += amount;
+ LOG.debug("freeing {} memory on node {}...avail mem: {}", amount,
this.getHostname(), _availMemory);
+ if (_availMemory > this.getTotalMemoryResources()) {
+ LOG.warn("Freeing more memory than there exists!");
--- End diff --
1. Grammar.
2. Should this be a simple warn? Sounds like a more serious condition,
maybe throw an exception?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
