Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47702493
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -38,15 +39,19 @@
public class TopologyDetails {
- String topologyId;
- Map topologyConf;
- StormTopology topology;
- Map<ExecutorDetails, String> executorToComponent;
- int numWorkers;
+ private String topologyId;
+ private Map topologyConf;
+ private StormTopology topology;
+ private Map<ExecutorDetails, String> executorToComponent;
+ private int numWorkers;
--- End diff --
will use "this." Change it to private since there are get methods to access
those variables
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
