Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/948#discussion_r47710294
--- Diff: storm-core/src/clj/backtype/storm/daemon/logviewer.clj ---
@@ -320,7 +320,7 @@
logs-groups (concat (conf LOGS-GROUPS)
group-wl)]
(or (some #(= % user) logs-users)
- (< 0 (.size (intersection (set groups) (set group-wl))))))))
+ (< 0 (.size (intersection (set groups) (set logs-groups))))))))
--- End diff --
Given that logs-groups was sitting there in line 322, and was not being
used at all prior to this pull request, this seems like it was intended to be
used like exactly you've changed it here. But the fact that it wasn't used
makes me think there is more in play here than meets the eyes.
Isn't group-wl already supposed to extract this information anyway?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
