[ 
https://issues.apache.org/jira/browse/STORM-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060328#comment-15060328
 ] 

ASF GitHub Bot commented on STORM-1393:
---------------------------------------

Github user knusbaum commented on a diff in the pull request:

    https://github.com/apache/storm/pull/949#discussion_r47804494
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
    @@ -1022,7 +1022,7 @@
               storm-home (System/getProperty "storm.home")
               storm-options (System/getProperty "storm.options")
               storm-conf-file (System/getProperty "storm.conf.file")
    -          storm-log-dir (or (System/getProperty "storm.log.dir") (str 
storm-home file-path-separator "logs"))
    +          storm-log-dir backtype.storm.config/LOG-DIR
    --- End diff --
    
    Here as well.


> Sort out storm.log.dir configure and add documentation about logs
> -----------------------------------------------------------------
>
>                 Key: STORM-1393
>                 URL: https://issues.apache.org/jira/browse/STORM-1393
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>    Affects Versions: 0.11.0
>            Reporter: Zhuo Liu
>            Assignee: Zhuo Liu
>            Priority: Minor
>             Fix For: 0.11.0
>
>
> Currently, we have reorganized logs in STORM-901 and STORM-1387, it is 
> preferable for us to document the changes out for avoiding confusion to 
> users. 
> Also, the util/LOG-DIR and the way supervisor to get storm.log.dir in 
> worker-launch is inaccurate since it does not take the storm-conf into 
> account. We should fix it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to