Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/921#discussion_r47951306
  
    --- Diff: 
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java
 ---
    @@ -97,7 +101,7 @@ public ResourceAwareStrategy(Cluster cluster, Topologies 
topologies) {
     
             if (spouts.size() == 0) {
                 LOG.error("Cannot find a Spout!");
    -            return null;
    +            return 
SchedulingResult.failure(SchedulingStatus.FAIL_INVALID_TOPOLOGY, "Cannot find a 
Spout!");
    --- End diff --
    
    If this is the case, shouldn't we have rejected the topology when it was 
first submitted to nimbus? It does not seem like we should have code to handle 
this case in the scheduler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to