Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/952#discussion_r47956485
--- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
@@ -1716,15 +1716,13 @@
(.remove uploaders location)
))
- (^String beginFileDownload [this ^String file]
- (mark! nimbus:num-beginFileDownload-calls)
+ (^String beginFileDownload
+ [this ^String file]
(check-authorization! nimbus nil nil "fileDownload")
- (check-file-access (:conf nimbus) file)
- (let [is (BufferFileInputStream. file)
+ (let [is (BufferInputStream. (.getBlob (:blob-store nimbus) file
nil) ^Integer (Utils/getInt (conf
STORM-BLOBSTORE-INPUTSTREAM-BUFFER-SIZE-BYTES) (int 65536)))
--- End diff --
Can we break this line up? Very hard to read.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
