[ 
https://issues.apache.org/jira/browse/STORM-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062986#comment-15062986
 ] 

ASF GitHub Bot commented on STORM-1399:
---------------------------------------

Github user ptgoetz commented on a diff in the pull request:

    https://github.com/apache/storm/pull/955#discussion_r47971375
  
    --- Diff: 
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/blobstore/BlobStoreTest.java
 ---
    @@ -76,6 +76,7 @@
     
       @Before
       public void init() {
    +    System.setProperty("test.build.data", "target/test/data");
         initializeConfigs();
         baseFile = new File("/tmp/blob-store-test-"+UUID.randomUUID());
    --- End diff --
    
    It breaks the blob store tests, and chasing down the root cause was getting 
to be a pain. At least writing test data to /tmp doesn't clutter up the source 
tree, but I would also like to avoid that as well. I figured we could address 
that separately.


> Blobstore tests should write data to `target` so it gets removed when running 
> `mvn clean`
> -----------------------------------------------------------------------------------------
>
>                 Key: STORM-1399
>                 URL: https://issues.apache.org/jira/browse/STORM-1399
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.11.0
>            Reporter: P. Taylor Goetz
>            Assignee: P. Taylor Goetz
>            Priority: Minor
>
> Currently the blobstore tests create files/directories in the current working 
> directory. It would be better to use `target` so they get deleted when 
> running `mvn clean` and are ignored by git.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to