Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47996336
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -489,17 +489,63 @@ public void validateField(String name, Object o) {
public static class PacemakerAuthTypeValidator extends Validator {
@Override
public void validateField(String name, Object o) {
- if(o == null) {
- throw new IllegalArgumentException( "Field " + name + "
must be set.");
+ if (o == null) {
+ throw new IllegalArgumentException("Field " + name + "
must be set.");
+ }
+
+ if (o instanceof String &&
+ (((String) o).equals("NONE") ||
+ ((String) o).equals("DIGEST") ||
+ ((String) o).equals("KERBEROS"))) {
+ return;
+ }
+ throw new IllegalArgumentException("Field " + name + " must be
one of \"NONE\", \"DIGEST\", or \"KERBEROS\"");
+ }
+ }
--- End diff --
Yup, but I am not sure why git thinks the diff is this. The spacing seems
to be identical. Git seems to have gotten confused which part was changed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
