[ 
https://issues.apache.org/jira/browse/STORM-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064204#comment-15064204
 ] 

ASF GitHub Bot commented on STORM-1393:
---------------------------------------

Github user jerrypeng commented on a diff in the pull request:

    https://github.com/apache/storm/pull/957#discussion_r48045895
  
    --- Diff: docs/documentation/Logs.md ---
    @@ -19,12 +19,12 @@ locates at ${storm.log.dir}/logs/workers-artifacts.
     Daemon and worker logs are allowed to view and download through Storm UI 
by authorized users.
     
     To improve the debugging of Storm, we provide the Log Search feature.
    -Log Search supports searching in a certain log file or in a topology's all 
log files:
    +Log Search supports searching in a certain log file or in all of a 
topology's log files:
     
    -String search in a log file: In the log page for a worker, a user can 
search a certain string, e.g., "Exception", in for a certain worker log. This 
search can happen for both normal text log or rolled ziplog files. In the 
results, the offset and matched lines will be displayed.
    +String search in a log file: In the log page for a worker, a user can 
search a certain string, e.g., "Exception", in for a certain worker log. This 
search can happen for both normal text log or rolled zip log files. In the 
results, the offset and matched lines will be displayed.
    --- End diff --
    
    remove "for" in "in for a certain worker log"
    
    log->logs in "This search can happen for both normal text log"


> Sort out storm.log.dir configure and add documentation about logs
> -----------------------------------------------------------------
>
>                 Key: STORM-1393
>                 URL: https://issues.apache.org/jira/browse/STORM-1393
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>    Affects Versions: 0.11.0
>            Reporter: Zhuo Liu
>            Assignee: Zhuo Liu
>            Priority: Minor
>             Fix For: 0.11.0
>
>
> Currently, we have reorganized logs in STORM-901 and STORM-1387, it is 
> preferable for us to document the changes out for avoiding confusion to 
> users. 
> Also, the util/LOG-DIR and the way supervisor to get storm.log.dir in 
> worker-launch is inaccurate since it does not take the storm-conf into 
> account. We should fix it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to