[
https://issues.apache.org/jira/browse/STORM-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069179#comment-15069179
]
ASF GitHub Bot commented on STORM-1175:
---------------------------------------
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/939#discussion_r48323074
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -0,0 +1,302 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.redis.state;
+
+import backtype.storm.state.DefaultStateSerializer;
+import backtype.storm.state.KeyValueState;
+import backtype.storm.state.Serializer;
+import org.apache.storm.redis.common.config.JedisPoolConfig;
+import
org.apache.storm.redis.common.container.JedisCommandsContainerBuilder;
+import
org.apache.storm.redis.common.container.JedisCommandsInstanceContainer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import redis.clients.jedis.JedisCommands;
+import sun.misc.BASE64Decoder;
+import sun.misc.BASE64Encoder;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * A redis based implementation that persists the state in Redis.
+ */
+public class RedisKeyValueState<K, V> implements KeyValueState<K, V> {
+ private static final Logger LOG =
LoggerFactory.getLogger(RedisKeyValueState.class);
+ private static final String COMMIT_TXID_KEY = "$commit";
--- End diff --
Since its internal, just followed a convention to differentiate it (similar
to checkpoint stream). But here there is no namespace collision so it could be
"commit" as well.
> State store for windowing operations
> ------------------------------------
>
> Key: STORM-1175
> URL: https://issues.apache.org/jira/browse/STORM-1175
> Project: Apache Storm
> Issue Type: Sub-task
> Reporter: Arun Mahadevan
> Assignee: Arun Mahadevan
>
> Windowing operations should be able to save the results of partial
> computations in a state store. This should persist across restarts and bolts
> should be able to look up the values from the store.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
