Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/972#discussion_r48849165
--- Diff: storm-core/src/jvm/backtype/storm/multilang/JsonSerializer.java
---
@@ -33,20 +33,24 @@
import org.json.simple.JSONValue;
import backtype.storm.task.TopologyContext;
-import backtype.storm.tuple.Tuple;
import backtype.storm.utils.Utils;
/**
* JsonSerializer implements the JSON multilang protocol.
*/
public class JsonSerializer implements ISerializer {
- private DataOutputStream processIn;
+ //ANY CHANGE TO THIS CODE MUST BE SERIALIZABLE COMPATIBLE OR THERE
WILL BE PROBLEMS
+ private static final long serialVersionUID = 8581179559440582569L;
+
+ public static final String DEFAULT_CHARSET = "UTF-8";
+
+ private BufferedWriter processIn;
private BufferedReader processOut;
--- End diff --
If we are setting the serialVersionUID (which I think is great) can we mark
processIn and processOut as transient?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
