[
https://issues.apache.org/jira/browse/STORM-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083124#comment-15083124
]
ASF GitHub Bot commented on STORM-1414:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/972#discussion_r48849165
--- Diff: storm-core/src/jvm/backtype/storm/multilang/JsonSerializer.java
---
@@ -33,20 +33,24 @@
import org.json.simple.JSONValue;
import backtype.storm.task.TopologyContext;
-import backtype.storm.tuple.Tuple;
import backtype.storm.utils.Utils;
/**
* JsonSerializer implements the JSON multilang protocol.
*/
public class JsonSerializer implements ISerializer {
- private DataOutputStream processIn;
+ //ANY CHANGE TO THIS CODE MUST BE SERIALIZABLE COMPATIBLE OR THERE
WILL BE PROBLEMS
+ private static final long serialVersionUID = 8581179559440582569L;
+
+ public static final String DEFAULT_CHARSET = "UTF-8";
+
+ private BufferedWriter processIn;
private BufferedReader processOut;
--- End diff --
If we are setting the serialVersionUID (which I think is great) can we mark
processIn and processOut as transient?
> Some improvements for multilang JsonSerializer
> ----------------------------------------------
>
> Key: STORM-1414
> URL: https://issues.apache.org/jira/browse/STORM-1414
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-multilang
> Reporter: Xin Wang
> Assignee: Xin Wang
> Priority: Minor
>
> Changes are the following:
> 1.Add a generated serialVersionUID & default charset 'UTF-8'
> 2.Use BufferedWriter for writing data
> 3.Remove unused variable 'anchors'
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
