[
https://issues.apache.org/jira/browse/STORM-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083129#comment-15083129
]
ASF GitHub Bot commented on STORM-1415:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/973#discussion_r48849410
--- Diff:
storm-core/src/jvm/storm/trident/state/map/MapCombinerAggStateUpdater.java ---
@@ -33,24 +33,25 @@
import storm.trident.tuple.TridentTupleView.ProjectionFactory;
public class MapCombinerAggStateUpdater implements StateUpdater<MapState> {
+ //ANY CHANGE TO THIS CODE MUST BE SERIALIZABLE COMPATIBLE OR THERE
WILL BE PROBLEMS
+ private static final long serialVersionUID = 4783054195826968400L;
+
CombinerAggregator _agg;
Fields _groupFields;
Fields _inputFields;
ProjectionFactory _groupFactory;
ProjectionFactory _inputFactory;
--- End diff --
Because we are setting the serialVersionUID now. Can we mark _groupFactory
and _inputFactory as transient? They are set in the prepare, so having them
not be transient is unneeded.
> Some improvements for trident map StateUpdater
> ----------------------------------------------
>
> Key: STORM-1415
> URL: https://issues.apache.org/jira/browse/STORM-1415
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Xin Wang
> Assignee: Xin Wang
> Priority: Minor
>
> Changes are the following:
> 1.Add a generated serialVersionUID
> 2.Remove unused variables 'groups' & 'values'
> 3.Add <> in order to pass compiler type check
> 4.Fix newline and whitespaces
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
