Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/991#discussion_r49005341
--- Diff:
external/storm-mqtt/core/src/main/java/org/apache/storm/mqtt/common/MqttUtils.java
---
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.mqtt.common;
+
+
+import org.fusesource.mqtt.client.QoS;
+
+public class MqttUtils {
+
+ private MqttUtils(){}
+
+ public static QoS qosFromInt(int i){
+ QoS qos = null;
+ switch(i) {
+ case 0:
+ qos = QoS.AT_MOST_ONCE;
+ break;
+ case 1:
+ qos = QoS.AT_LEAST_ONCE;
+ break;
+ case 2:
+ qos = QoS.EXACTLY_ONCE;
--- End diff --
I'm with the approach what @ptgoetz is intended.
But it is still not intuitive for user side, since that numbers doesn't
make sense to match actual meaning of QoS.
If we guarantee that we always support AT_MOST_ONCE, AT_LEAST_ONCE,
EXACTLY_ONCE as QoS (I mean we will not drop QoS when switching the MQTT
client), we can make our own enum to wrap.
If those numbers are a part of MQTT protocol then I'm fine to leave as it
is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
