[
https://issues.apache.org/jira/browse/STORM-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089388#comment-15089388
]
ASF GitHub Bot commented on STORM-1030:
---------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/871#issuecomment-170037330
Sorry this took so long to get back to. The code looks good for the most
part. I have a few minor formatting nits, but the header needs to be updated
and I would like to see the metric registered with a non-zero poll interval.
> Hive Connector Fixes
> --------------------
>
> Key: STORM-1030
> URL: https://issues.apache.org/jira/browse/STORM-1030
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-hive
> Reporter: Sriharsha Chintalapani
> Assignee: Sriharsha Chintalapani
> Fix For: 0.11.0
>
>
> 1. Schedule Hive transaction heartbeats outside of execute method.
> 2. Fix retiring idleWriters
> 3. Do not call flush if there is no data added to a txnbatch
> 4. Catch any exception and abort transaction.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
